Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup]: this. property fallback id:this-property-fallback #19736

Closed
wants to merge 2 commits into from

Conversation

snewcomer
Copy link
Contributor

@snewcomer snewcomer commented Aug 29, 2021

ref Ember.js issue - #19617

Ref Glimmer PR - glimmerjs/glimmer-vm#1331

The Glimmer PR must be included in this build first to avoid VM_DEPRECATION_OVERRIDES errors. e.g. this test - the scoped variable is not available outside the {{#each}} block

@nlfurniss
Copy link
Contributor

This needs to be cleaned up in glimmer-vm in conjunction if I’m not mistaken

@snewcomer
Copy link
Contributor Author

snewcomer commented Aug 30, 2021

Yep there is a PR! (a few of them as well for other ones)

glimmerjs/glimmer-vm#1331

@snewcomer
Copy link
Contributor Author

pulled into #19762

@snewcomer snewcomer closed this Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants